Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guarantee widget.Form tracks all entry validation changes, fixes #1965 #1985

Merged
merged 2 commits into from Feb 21, 2021

Conversation

fpabl0
Copy link
Member

@fpabl0 fpabl0 commented Feb 20, 2021

Description:

Fixes #1965

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bug fix looks good, but the resulting test images show an invalid state - two focused elements at once. I don't know that fixing this is in scope for the ticket, but we should not commit invalid test images, so perhaps a line or to for Canvas.Focus() might help in the meantime?

@fpabl0
Copy link
Member Author

fpabl0 commented Feb 20, 2021

Yes, I am aware of it, sorry about that, I tried to unfocus them, but have no success.

Canvas.Focus() might help in the meantime?

Oh, I will try with that, later today.

@fpabl0
Copy link
Member Author

fpabl0 commented Feb 20, 2021

@andydotxyz Unfortunately, Canvas.Focus() didn't work, so I manually unfocused one entry, do now the test images look good? Or should I unfocus both of them?

@andydotxyz
Copy link
Member

@andydotxyz Unfortunately, Canvas.Focus() didn't work, so I manually unfocused one entry, do now the test images look good? Or should I unfocus both of them?

Yeah that's OK for now. I suspect the focus issue requires a fix in the text code which we can look at separately.

Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, though I would appreciate @Jacalz thoughts as well

@Jacalz Jacalz merged commit 7d2b239 into fyne-io:develop Feb 21, 2021
@fpabl0 fpabl0 deleted the fix/1965 branch February 21, 2021 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants