Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to an infinite queue for binding callbacks #1996

Merged
merged 2 commits into from Mar 1, 2021

Conversation

andydotxyz
Copy link
Member

Fixes #1838

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@andydotxyz
Copy link
Member Author

I can’t quite make sense of the benchmark results because the way the code changed impacts how it is reported, but it looks like CPU-wise a similar speed. However it requires more memory than the previous version, though of course it scales based on how many items you simultaneously trigger

This should make small apps just as performant as before the change
Copy link
Member

@fpabl0 fpabl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andydotxyz
Copy link
Member Author

Thanks for the 👍 @fpabl0. This has now been open for comment for over 7 days so we'll merge it and test through release process. Better solutions may be found for future releases.

@andydotxyz andydotxyz merged commit a9fe32d into fyne-io:develop Mar 1, 2021
@andydotxyz andydotxyz deleted the fix/1838 branch March 1, 2021 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants