Add calculations to apply hover over high importance buttons #2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpabl0
reviewed
Feb 23, 2021
widget/button.go
Outdated
| outG := alpha*float32(dstG) + (1-alpha)*float32(srcG) | ||
| outB := alpha*float32(dstB) + (1-alpha)*float32(srcB) | ||
| outA := alpha*float32(dstA) + (1-alpha)*float32(srcA) | ||
| return color.RGBA{R: uint8(uint32(outR) >> 8), G: uint8(uint32(outG) >> 8), B: uint8(uint32(outB) >> 8), A: uint8(uint32(outA) >> 8)} |
There was a problem hiding this comment.
Oh that was my mistake 😅 I forgot to do it. Great!! I was beginning to be afraid of colors 😂
fpabl0
reviewed
Feb 23, 2021
widget/button.go
Outdated
| outB := alpha*float32(dstB) + (1-alpha)*float32(srcB) | ||
| outA := alpha*float32(dstA) + (1-alpha)*float32(srcA) | ||
| return color.RGBA{R: uint8(uint32(outR) >> 8), G: uint8(uint32(outG) >> 8), B: uint8(uint32(outB) >> 8), A: uint8(uint32(outA) >> 8)} | ||
| } | ||
| return theme.HoverColor() |
There was a problem hiding this comment.
I think the above change should have the normal button color too, because if someone use a custom theme and change the button Color, it would not look great if button is colored directly to the hover Color.
Correct, and optimise, maths for non-pre-mul channels.
Jacalz
requested changes
Feb 24, 2021
This bug fix applies the current hover colour to all buttons. |
Jacalz
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not adding a new colour so could be improved in the future, for now mathematically combine the hover colour already specified.
Fixes #1785
Checklist: