Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added additional documentation and example code snippet. #2156

Merged
merged 9 commits into from May 22, 2021
Merged

Added additional documentation and example code snippet. #2156

Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6808a8c
Added additional documentation and example code snippet.
Apr 11, 2021
12d2272
Update dialog/folder.go
lazyhacker Apr 21, 2021
93fa956
Merge pull request #1 from fyne-io/develop
lazyhacker Apr 21, 2021
1d4725e
Remove code snippet per review feedback.
lazyhacker Apr 23, 2021
b142ab7
Clarified wording per review comments.
lazyhacker Apr 24, 2021
9551c9b
Add comment about when the callback function is called and when it gets
lazyhacker Apr 24, 2021
9bf6bca
Added comment on when callback function is called and when it gets a …
lazyhacker Apr 24, 2021
1b461a6
Merge branch 'fyne-io:develop' into develop
lazyhacker May 15, 2021
a86eea6
Changed spacing between sentences to single. Fyne uses the single sp…
lazyhacker May 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion dialog/folder.go
View file
Open in desktop
Expand Up @@ -19,7 +19,10 @@ func NewFolderOpen(callback func(fyne.ListableURI, error), parent fyne.Window) *
return dialog
}

// ShowFolderOpen creates and shows a file dialog allowing the user to choose a folder to open.
// ShowFolderOpen creates and shows a file dialog allowing the user to choose a
// folder to open. The callback function will run when the dialog closes. The
// URI will be nil when nothing is selected or cancelled.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest change made this slightly ambiguous sorry - "nothing is selected or cancelled".
I think "the user cancelled or nothing is selected" is clearer.

//
// The dialog will appear over the window specified.
//
// Since: 1.4
Expand Down