Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Form does not render HintTexts for more than one item #2178

Merged
merged 2 commits into from Apr 19, 2021
Merged

Fix Form does not render HintTexts for more than one item #2178

merged 2 commits into from Apr 19, 2021

Conversation

AnkushJadhav
Copy link
Contributor

Description:

The AppendItem API was not formatting the HintText as an input, resulting in it not being rendered on Refresh.

Fixes #2028

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

andydotxyz
andydotxyz approved these changes Apr 19, 2021
View reviewed changes
Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix, thanks

@andydotxyz andydotxyz merged commit 7c9f320 into fyne-io:develop Apr 19, 2021
@AnkushJadhav AnkushJadhav deleted the fix/2028 branch April 24, 2021 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andydotxyz andydotxyz andydotxyz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AnkushJadhav @andydotxyz