Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove stale builds #2203

Merged
merged 1 commit into from Apr 28, 2021
Merged

Remove stale builds #2203

merged 1 commit into from Apr 28, 2021

Conversation

andydotxyz
Copy link
Member

Description:

If no executable was specified, but one was in place,
assume it is stale and remove

Fixes #2154

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@andydotxyz
Remove stale builds
41503af 
If no executable was specified, but one was in place,
assume it is stale and remove
@andydotxyz andydotxyz mentioned this pull request Apr 27, 2021
Closed
fpabl0
fpabl0 approved these changes Apr 27, 2021
View reviewed changes
Copy link
Member

@fpabl0 fpabl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is good, but I think maybe the help usage should be improved (for the -exe flag), until now I didn't understand what did that flag do 🤔

@andydotxyz andydotxyz merged commit 28abc8d into fyne-io:release/v2.0.x Apr 28, 2021
@andydotxyz
Copy link
Member Author

This change is good, but I think maybe the help usage should be improved (for the -exe flag), until now I didn't understand what did that flag do 🤔

Yes it was out of date. I have updated to:
"Specify an existing binary instead of building before package"

@andydotxyz andydotxyz deleted the removeoldexe branch April 28, 2021 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpabl0 fpabl0 fpabl0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andydotxyz @fpabl0