Add missing position info in ScrollEvent

[andydotxyz]

Fixes #2199

Checklist:

• Tests included.
• Lint and formatter run with no errors.
• Tests all pass.

[fpabl0]

I am not sure why, but I cannot make the tests pass locally, I always get:

=== RUN   TestWindow_Scrolled
    .../fyne/internal/driver/glfw/window_test.go:547:
        	Error Trace:	window_test.go:547
        	Error:      	Expected value not to be nil.
        	Test:       	TestWindow_Scrolled
        	Messages:   	scroll event

[andydotxyz]

I am not sure why, but I cannot make the tests pass locally, I always get:

=== RUN   TestWindow_Scrolled
    .../fyne/internal/driver/glfw/window_test.go:547:
        	Error Trace:	window_test.go:547
        	Error:      	Expected value not to be nil.
        	Test:       	TestWindow_Scrolled
        	Messages:   	scroll event

Strange. Does it work if you apply this change?

--- a/internal/driver/glfw/window_test.go
+++ b/internal/driver/glfw/window_test.go
@@ -537,14 +537,14 @@ func TestWindow_HoverableOnDragging(t *testing.T) {
 func TestWindow_Scrolled(t *testing.T) {
        w := createWindow("Test").(*window)
        o := &scrollable{Rectangle: canvas.NewRectangle(color.White)}
-       o.SetMinSize(fyne.NewSize(100, 100))
        w.SetContent(o)
+       w.Resize(fyne.NewSize(100, 100))

[fpabl0]

@andydotxyz

However it works just fine because ScrollEvent is a PointEvent as well

Hmm, not sure, as far as I know, that is not possible in any go version. When you assert a type by pointer, it should be exactly that type. Partial asserts is only possible when you are asserting behaviors (using interfaces) not values.

That test would fail in go playground too:
https://play.golang.org/p/-oldmGnFedA

[fpabl0]

Strange. Does it work if you apply this change?

The problem was only the type assertion, using ScrollEvent instead of PointEvent is enough :)

[fpabl0]

Tests work now :). However I am still worried about the fact that it works before, it should not.

[andydotxyz]

However I am still worried about the fact that it works before, it should not.

Yes, I agree. It seems that test file is not running on CI - so the logical solution is that my git hooks did not fire AND that I did not run the test on its final version. Which is sadly possible.

Glad it's all running now :)