Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait for goroutines to finish when firing a change to an app preferences #2246

Merged
merged 7 commits into from May 24, 2021
Merged

Wait for goroutines to finish when firing a change to an app preferences #2246

merged 7 commits into from May 24, 2021

Commits on May 15, 2021

  1. fixes fyne-io#2241

    @s77rt
    s77rt committed May 15, 2021
    Configuration menu
    Copy the full SHA
    4ea39dc View commit details
    Browse the repository at this point in the history

  2. clearer code to create a new preferences implementation stored in memory

    @s77rt
    s77rt committed May 15, 2021
    Configuration menu
    Copy the full SHA
    87c93cf View commit details
    Browse the repository at this point in the history

Commits on May 16, 2021

  1. used goimports for better code formating

    @s77rt
    s77rt committed May 16, 2021
    Configuration menu
    Copy the full SHA
    f77a96b View commit details
    Browse the repository at this point in the history

Commits on May 17, 2021

  1. changed variable name so it's not the same as it's type: 

    waitGroup *sync.WaitGroup to wg *sync.WaitGroup
    @s77rt
    s77rt committed May 17, 2021
    Configuration menu
    Copy the full SHA
    18cceb5 View commit details
    Browse the repository at this point in the history

  2. enhanced code that wg.Add(), wg.Done() and wg.Wait() are not separate… 

    …d so it's easier to debug
    @s77rt
    s77rt committed May 17, 2021
    Configuration menu
    Copy the full SHA
    7e93970 View commit details
    Browse the repository at this point in the history

  3. fixed: loop variable l captured by func literal

    @s77rt
    s77rt committed May 17, 2021
    Configuration menu
    Copy the full SHA
    b55449b View commit details
    Browse the repository at this point in the history

Commits on May 19, 2021

  1. re-typed a comment

    @s77rt
    s77rt committed May 19, 2021
    Configuration menu
    Copy the full SHA
    d025ffd View commit details
    Browse the repository at this point in the history