Fixed: Tapped being triggered after Drag #2248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmscott
previously approved these changes
May 17, 2021
There was a problem hiding this comment.
This change fixed the issue in my limited local testing 👍
@andydotxyz could this land in the next 2.0.x?
|
Yes it can land in 2.0.x - but can we get a test as well please, make it part of our suite of checks @s77rt ? |
… button == desktop.MouseButtonSecondary
|
@andydotxyz updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added a new condition before firing the Tapped and SecondaryTapped events that we are not dragging
Fixes #2235
Checklist: