Fix toolbar to be the standard widget height #2265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To do this right then low profile buttons are fixed as well. This knocked on to accordion (header) and app/doc tabs. All positive changes IMHO :) Fixes fyne-io#2257
Jacalz
requested changes
Jun 3, 2021
There was a problem hiding this comment.
Hmm, in general, I think this is a good change, but I am not quite sure that I like the new height of the tabs, though it is hard to say as it might just take some getting used to :)
I also noticed that the tabs change their height when the tab drop-down button appears or disappears. That should probably be fixed.
|
I cannot replicate any height change - can you provide the steps in detail please? |
|
I hope that this should be sufficient: |
|
Oh, I see it now many thanks. |
Jacalz
requested changes
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To do this right then low profile buttons are fixed as well.
This knocked on to accordion (header) and app/doc tabs.
All positive changes IMHO :)
Fixes #2257
Checklist: