Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the platform specific scancode available #2294

Merged
merged 4 commits into from Aug 15, 2021

Conversation

andydotxyz
Copy link
Member

This is a complex topic and the int will vary based on platform (macOS is strange).
Some applications need a reference to the source and we can't expose GLFW abstraction

Fixes #1523

Checklist:

  • Tests included. <- we don't have any way to test glfw generated events
  • Lint and formatter run with no errors.
  • Tests all pass.

andydotxyz and others added 2 commits June 21, 2021 19:43
This is a complex topic and the int will vary based on platform (macOS is strange).
Some applications need a reference to the source and we can't expose GLFW abstraction
And update the docs to make it clear
@MagicalTux
Copy link
Contributor

We still have some issues, see https://github.com/andydotxyz/fyne/blob/fix/1523/internal/driver/glfw/window.go#L1169

  • If the key name is empty (key unknown to fyne), the event won't fire. I do not think it's an issue if the event fires with keyName = "" because it just won't do anything, and it's unlikely to be any issue in terms of performance/etc. Might be good to add in the documentation a note about it.
  • I was about to talk about the tab key but it seems it's solved in fyne 2.1+ with fyne.Tabbable

Because we now fire on hardware info that will be present on many devices
@andydotxyz
Copy link
Member Author

I think the last update should fix your point about unrecognised events

We will be adding location name somehow soon in another PR
@andydotxyz
Copy link
Member Author

Review period lapsed

@andydotxyz andydotxyz merged commit 5304bfa into fyne-io:develop Aug 15, 2021
@andydotxyz andydotxyz deleted the fix/1523 branch August 15, 2021 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants