Fix single pixel lines

[andydotxyz]

Description:

Better support single px lines even on hidpi screens

Fixes #2298

Checklist:

• Tests included.
• Lint and formatter run with no errors.
• Tests all pass.

[Jacalz]

Are the iOS build changes supposed to be part of this PR? It looks to be a good change, but it seems like it might have accidentally slipped in.

[Jacalz]

The lines on the colour wheels in the test images looks like they are almost too thin. Is that expected? If yes, should we perhaps make them a bit thicker?

[andydotxyz]

The lines on the colour wheels in the test images looks like they are almost too thin. Is that expected? If yes, should we perhaps make them a bit thicker?

They were coded as 0px thick, so drawing them as thin as possible is probably what was intended?

[andydotxyz]

Are the iOS build changes supposed to be part of this PR? It looks to be a good change, but it seems like it might have accidentally slipped in.

I think it's some weird merge / rebase artefact - I have re-merged in develop and the changes don't appear in the diff.

[Jacalz]

The lines on the colour wheels in the test images looks like they are almost too thin. Is that expected? If yes, should we perhaps make them a bit thicker?

They were coded as 0px thick, so drawing them as thin as possible is probably what was intended?

Hmm, maybe.I personally think that they would look better a little bit thicker, closer to before this change.

[andydotxyz]

Hmm, maybe.I personally think that they would look better a little bit thicker, closer to before this change.

This is a subjective matter. I far prefer hairlines like that to be as thin as possible.
The old version was 2px thick, the new is 1px - there isn't really an in-between.
If it needs to be adjusted I'd say we do so separately to this.

[Jacalz]

Hmm, maybe.I personally think that they would look better a little bit thicker, closer to before this change.

This is a subjective matter. I far prefer hairlines like that to be as thin as possible.

The old version was 2px thick, the new is 1px - there isn't really an in-between.

If it needs to be adjusted I'd say we do so separately to this.

Alright then. I'd have preferred keeping them as thick as before, but I'm going to approve this.

[andydotxyz]

Alright then. I'd have preferred keeping them as thick as before, but I'm going to approve this.

Maybe we should review it with @stuartmscott when he gets back, as he was the original author?
I won't pull it into v2.0.x so we have more time to reflect on whether it should be changed.