Export table scrolling methods #2317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ScrollTo, ScrollToEnd, ScrollToStart - addresses fyne-io#1892
|
Is End and Start best? It seems unlikely that bottom-right is more useful than bottom left? How about top and bottom like list with possible leading and trailing as well? |
|
So, what would leading and trailing do? scroll all the way left and all the way right, without changing the vertical offset? |
|
Yes I think so, if that makes sense? |
- these replace ScrollToStart() and ScrollToEnd()
andydotxyz
requested changes
Jul 12, 2021
andydotxyz
approved these changes
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds the following public methods to widget.Table:
Fixes #1892
Checklist:
I'm not certain about the public API style. The issue mentioned creating ScrollToTop() and ScrollToBottom() but a table is 2D, so I went with ScrollToStart() and ScrollToEnd(). Any thoughts on this?
I figured I'd get some feedback on this before working on scrolling for widget.Tree