Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/scroll tree #2319

Merged
merged 4 commits into from Jul 12, 2021
Merged

Feature/scroll tree #2319

merged 4 commits into from Jul 12, 2021

Conversation

nealmcc
Copy link
Contributor

@nealmcc nealmcc commented Jul 11, 2021

Description:

Adds the following exported methods to widget.Tree:

  • ScrollToTop()
  • ScrollToBottom()
  • ScrollTo(TreeNodeID)

Fixes #1892

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

Where applicable:

  • Public APIs match existing style.

Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, just notes about comments and Since.

Also are the test images required? All we are testing is that the offset changes I think.
If you do want to serialise the output please use the Markup style instead of image - it is much smaller on the repo and easier to track changes. We are trying to move to using image tests just for validating render (i.e initial look and theme change)

widget/tree.go Outdated Show resolved Hide resolved
@nealmcc
Copy link
Contributor Author

nealmcc commented Jul 12, 2021

Nice, just notes about comments and Since.

Also are the test images required? All we are testing is that the offset changes I think.
If you do want to serialise the output please use the Markup style instead of image - it is much smaller on the repo and easier to track changes. We are trying to move to using image tests just for validating render (i.e initial look and theme change)

Makes sense - in large part I was using the image assertion to see what a tree widget looked like, and how it behaved - I hadn't used them before :)

@nealmcc
Copy link
Contributor Author

nealmcc commented Jul 12, 2021

Should be good to go now :)

@nealmcc nealmcc requested a review from andydotxyz July 12, 2021 21:19
Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thanks

@andydotxyz andydotxyz merged commit 72c09a8 into fyne-io:develop Jul 12, 2021
@nealmcc nealmcc deleted the feature/scrollTree branch July 13, 2021 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants