Add Alignment to Select #2336
Merged
Add Alignment to Select #2336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to pass it all the way down to menu item. Do so internally for now, as we don't need to expose alignment of menu items publicly. Fixes fyne-io#2329
fpabl0
reviewed
Jul 27, 2021
|
Sorry @fpabl0 - merge conflicts had to be resolved. |
fpabl0
approved these changes
Jul 28, 2021
| @@ -1370,7 +1370,7 @@ func TestWindow_SetPadded(t *testing.T) { | |||
| if hasNativeMenu() { | |||
| menuHeight = 0 | |||
| } else { | |||
| menuHeight = widget.NewToolbar(widget.NewToolbarAction(theme.ContentCutIcon(), func() {})).MinSize().Height | |||
There was a problem hiding this comment.
if the canvas text is empty, will it return a height different from 0?
There was a problem hiding this comment.
Yes, the height of text is defined by its parameters - the width is what changes based on content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to pass it all the way down to menu item. Do so internally for now,
as we don't need to expose alignment of menu items publicly.
Fixes #2329
Checklist: