Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/1833 #2390

Merged
merged 2 commits into from Aug 20, 2021
Merged

Fix/1833 #2390

merged 2 commits into from Aug 20, 2021

Conversation

andydotxyz
Copy link
Member

Description:

Remove deprecated APIs to fix macOS warnings.
Sadly the new notifications are not as flexible as the old ones (apps must be signed) but we can't avoid that.
So we fall back to the script based ones instead.

Fixes #1833

Checklist:

  • Tests included. <- no new tests, switching out calls for existing features
  • Lint and formatter run with no errors.
  • Tests all pass.

Sadly this requires the apps to be signed, so it only really works for store-distributed apps.
But it's required because of the deprecations.

Fixes fyne-io#1833
Copy link
Member

@toaster toaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I had an old branch on my disk which contained a similar implementation but I also set a delegate into the notification center. However, I’m not sure what this is good for :).

@andydotxyz andydotxyz merged commit 12e525e into fyne-io:develop Aug 20, 2021
@andydotxyz andydotxyz deleted the fix/1833 branch August 20, 2021 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants