Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some bad offset maths #2405

Merged
merged 1 commit into from Aug 27, 2021
Merged

Fix some bad offset maths #2405

merged 1 commit into from Aug 27, 2021

Conversation

andydotxyz
Copy link
Member

Fixes #2387

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@stuartdd
Copy link

Andy
I have spent 40 years in software development and even some years in corporate dev with git in BT but I do not know how to pull the fix, or where to put it so that the dev environment on my linux box builds with it. It is my git + go knowledge that is lacking.

Is it possible to update the go.mod file and let go do the work or are there specific pull requests from git.

I am happy to review the code but obviously as I raised the issue it should be me to sign off on it. I am just not sure of the process.

Is there a doc or site that explains the process. I would love to get up to speed with the process and contribute.

Regards

Stuart

@andydotxyz
Copy link
Member Author

Not a problem, the easiest way is to use the Go module replace directive - add this to the end of your go.mod:

replace fyne.io/fyne/v2 => github.com/andydotxyz/fyne/v2 07e8477c8

Then run go mod tidy and you'll be running on top of my PR.

Copy link

@stuartdd stuartdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Andy I can confirm that the changes work.
I have updated my go.mod files to use 07e8477 (as described)
I can see the changes and the issue is now resolved.

@andydotxyz andydotxyz merged commit 59fbf74 into fyne-io:develop Aug 27, 2021
@andydotxyz andydotxyz deleted the fix/2387 branch August 27, 2021 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants