Fix Android builds for darwin/arm64 #2440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andydotxyz
reviewed
Sep 7, 2021
| @@ -326,6 +326,13 @@ func archNDK() string { | |||
| arch = "x86" | |||
| case "amd64": | |||
| arch = "x86_64" | |||
| case "arm64": | |||
| // For darwin/arm64, see https://golang.org/cl/346153. | |||
| if runtime.GOOS == "darwin" { | |||
There was a problem hiding this comment.
Why if darwin? I thought this was a fix for Android NDK not supporting arm64?
There was a problem hiding this comment.
It's for building android on a darwin/arm64 machine. Hence, GOOS == darwin, and the GOARCH is arm64.
I personally don't want to write the darwin check, but in the Go's CL review process, the Go team suggests to better just check for darwin, because on arm64 platforms, only darwin is (partially )supported in NDK. They don't want to risk an undefined behavior such as someone using linux/arm64 or windows/arm64 where NDK does not yet fully supported.
Besides, on a darwin/arm64 machine, using x86_64 is a temporary solution (yet) because NDK does not have any arm64 distribution at the moment.
andydotxyz
approved these changes
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
fyne packagecurrently does not work on Apple M1 Macs, this change fixes this situation. See relevant gomobile discussion: https://golang.org/cl/346153Fixes #2439
Checklist: