Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

list: implements the Focusable interface #3281

Merged
merged 1 commit into from
Oct 1, 2022
Merged

list: implements the Focusable interface #3281

merged 1 commit into from
Oct 1, 2022

Conversation

lucor
Copy link
Member

@lucor lucor commented Sep 24, 2022

Description:

This PR implements the Focusable interface for the listItem widget. This allows to handle some keyboard behaviours:

  • handle the focus when tab / shift+tab is pressed;
  • select the focused listItem when space is pressed;

Related to #1515

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

This commit implements the Focusable interface for the `listItem` widget.
This allows to handle some keyboard behaviours:
- handle the focus when `tab` / `shift+tab` is pressed;
- select the focused listItem when `space` is pressed;

Related to #1515
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 61.353% when pulling a4a2168 on lucor:list-focusable into 815bd1f on fyne-io:develop.

Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea. Looks good to me :)

@lucor lucor merged commit 61ced99 into fyne-io:develop Oct 1, 2022
@lucor lucor deleted the list-focusable branch October 1, 2022 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants