Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement kayboard navigation in widget.Tree #3530

Closed
wants to merge 2 commits into from

Conversation

Jacalz
Copy link
Member

@Jacalz Jacalz commented Jan 1, 2023

Description:

This implements the Focusable interface for Tree Nodes. Added keyboard navigation:

  • Navigate between tree nodes using tab and shift + tab.
  • Select a tree node by pressing space.
  • Open a branch by pressing right and close using left.

For #1515

Opening as draft for now until I have implemented tests.

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@Jacalz Jacalz changed the title Tree focusable Implement kayboard navigation in widget.Tree Jan 1, 2023
@coveralls
Copy link

Coverage Status

Coverage: 61.993% (-0.04%) from 62.031% when pulling 9361045 on Jacalz:tree-focusable into c0e25eb on fyne-io:develop.

@andydotxyz
Copy link
Member

It seems like up/down would pair better with left/right than tab/shift+tab do...

@Jacalz
Copy link
Member Author

Jacalz commented Jan 2, 2023

But the focusing controls that landed in the List widget a while ago just uses Tab?

@andydotxyz
Copy link
Member

andydotxyz commented Jan 2, 2023

But the focusing controls that landed in the List widget a while ago just uses Tab?

Ah. Oops. On playing with it I don't think that is the best behaviour, it is just the default because we didn't put key handling smarts into List.
Unfortunately it needs work on List as it will only tab through visible widgets - it really should handle moving up and down the list of items full, not just those rendered.

@Jacalz
Copy link
Member Author

Jacalz commented Jan 8, 2023

I'll close this and work on some other items that I prioritize higher. My backlog is getting rather big and with my limited spare time, I prefer to work on improvements that I will be making use of in the near future. Sorry.

@Jacalz Jacalz closed this Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants