New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4472 focus list item on select #4474
base: develop
Are you sure you want to change the base?
4472 focus list item on select #4474
Conversation
The includes a commit from Drew. Have you based the branch on the |
Also, please always fill out the checklist in the template and try to add some tests. |
I think the tests won't run because of the same (re)base issue showing the stray commit. |
39940c0
to
0bf5d62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be working now. Can you please add a test for it?
0bf5d62
to
04ae6da
Compare
I ran the test on |
Mobile test failed - I can either change the test or change the code. Does someone know why the code doesn't focus the list for mobile? I was trying to change as little as possible but figured it might be worth asking. li.onTapped = func() {
if !fyne.CurrentDevice().IsMobile() {
canvas := fyne.CurrentApp().Driver().CanvasForObject(l.list)
if canvas != nil {
canvas.Focus(l.list)
}
l.list.currentFocus = id
}
l.list.Select(id) |
Description:
Fixes #4472
Checklist:
Where applicable: