Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow tapped events with mouse movement to reach underlying widgets in Scroll #4528

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Allow tapped events with mouse movement to reach underlying widgets in Scroll #4528

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 0 additions & 16 deletions internal/widget/scroller.go
View file
Open in desktop
Expand Up @@ -55,7 +55,6 @@ func (r *scrollBarRenderer) Refresh() {
}

var _ desktop.Hoverable = (*scrollBar)(nil)
var _ fyne.Draggable = (*scrollBar)(nil)

type scrollBar struct {
Base
Expand Down Expand Up @@ -402,21 +401,6 @@ func (s *Scroll) ScrollToTop() {
s.scrollBy(0, -s.Offset.Y)
}

// DragEnd will stop scrolling on mobile has stopped
func (s *Scroll) DragEnd() {
}

// Dragged will scroll on any drag - bar or otherwise - for mobile
func (s *Scroll) Dragged(e *fyne.DragEvent) {
if !fyne.CurrentDevice().IsMobile() {
return
}

if s.updateOffset(e.Dragged.DX, e.Dragged.DY) {
s.refreshWithoutOffsetUpdate()
}
}

// MinSize returns the smallest size this widget can shrink to
func (s *Scroll) MinSize() fyne.Size {
min := fyne.NewSize(scrollContainerMinSize, scrollContainerMinSize).Max(s.minSize)
Expand Down