Widget scrolling plus #4701
Widget scrolling plus #4701
Conversation
widget/table.go
Outdated
| @@ -344,6 +344,17 @@ func (t *Table) TouchCancel(*mobile.TouchEvent) { | |||
| // Implements: fyne.Focusable | |||
| func (t *Table) TypedKey(event *fyne.KeyEvent) { | |||
| switch event.Name { | |||
| case fyne.KeyHome: | |||
| t.ScrollToTop() | |||
| t.Refresh() | |||
There was a problem hiding this comment.
The Refresh() calls here should not be necessary since the Scroll APIs already refresh
There was a problem hiding this comment.
You were partially right.
The default ScrollToTop/ScrollToBottom did not work correctly, a t.content.Refresh() was missing before t.finishScroll(), so I added it. Without it, it does scroll to top or bottom, but the table becomes blank.
There was a problem hiding this comment.
Sorry this has sat for so long. Something doesn't seem right though. Are you saying that the current "ScrollToTop" or "ScrollToBottom" don't work unless there is a Refresh call in the developers code?
| @@ -541,6 +552,33 @@ func (t *Table) ScrollToTop() { | |||
| t.finishScroll() | |||
| } | |||
|
|
|||
| // scrollByOnePage scrolls down or up by table height | |||
| func (t *Table) scrollByOnePage(down bool) { | |||
| if t.Length == nil || t.content == nil { | |||
There was a problem hiding this comment.
You may need to add some offset validation here - please test what happens if you try to keep scrolling when you're already at the top or bottom of the list
There was a problem hiding this comment.
It does not go out of bounds!
There is one bug in the tree widget, but its not introduced with this PR, it just became obvious after implementing it.
When you call tree.ScrollToBottom() twice, the last row's top border vanishes.
Other than that, there are no problems. Not sure if I should investigate it, since its not part of this PR.
I can share some example code (120 lines).
Description:
Fixes #4695
Checklist:
Where applicable: