Some text improvements including falling back to system fonts #4721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…obal scripts" attempt This is a first pass and will need more work to become dynamic as runes require...
|
Still some tests to revise, but this is pretty much code complete I think.
|
Not sure what happened there
This was referenced Mar 29, 2024
|
How much work is left for this to be ready? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes are in separate commits, the fallback code is basically first-pass.
We include lookup for OS font for the current language and whatever font the OS has for japanese, which typically includes most script languages.
This provides good (tested) coverage of rendering out of the box for macOS, iOS, Linux and Android (windows still to be tested).
Memory increase is currently 5% - 20% depending on how many fonts the app uses.
There are more optimisations to come that will counteract the increase.
The code is now faster than before so that's the current tradeoff
Fixes #(issue)
Checklist: