New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Double-click to select a file in FileOpen / FileSave dialogs #4794
Conversation
This is a lot more functionality into the fileItem to handle one new callback - can you talk through why this was necessary? I would have thought that either you could add DoubleTapped to the item (it should not delay as it does not actually have a single tapped handler - that is in the parent). Thanks for working on this, I just want to check this is the simplest approach. |
Since fileDialogItem also needs to handle click events (which were previously handled by grid or list), the click event of the list seems to override the event of the item. Therefore, I moved the click event handling into fileDialogItem as well. |
Co-authored-by: Drew Weymouth <dweymouth@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now, but I think we should give @andydotxyz a chance to take another look
Description:
Support Double-click to select a file in FileOpen / FileSave dialogs
Fixes #4676
Checklist: