Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double-click to select a file in FileOpen / FileSave dialogs #4794

Merged
merged 8 commits into from Apr 27, 2024

Conversation

Dorbmon
Copy link
Contributor

@Dorbmon Dorbmon commented Apr 19, 2024

Description:

Support Double-click to select a file in FileOpen / FileSave dialogs

Fixes #4676

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@coveralls
Copy link

coveralls commented Apr 19, 2024

Coverage Status

coverage: 64.892% (+0.03%) from 64.861%
when pulling 0fe8f75 on Dorbmon:4700418
into 66b892d on fyne-io:develop.

@andydotxyz
Copy link
Member

This is a lot more functionality into the fileItem to handle one new callback - can you talk through why this was necessary?

I would have thought that either you could add DoubleTapped to the item (it should not delay as it does not actually have a single tapped handler - that is in the parent).

Thanks for working on this, I just want to check this is the simplest approach.

@Dorbmon
Copy link
Contributor Author

Dorbmon commented Apr 23, 2024

This is a lot more functionality into the fileItem to handle one new callback - can you talk through why this was necessary?

I would have thought that either you could add DoubleTapped to the item (it should not delay as it does not actually have a single tapped handler - that is in the parent).

Thanks for working on this, I just want to check this is the simplest approach.

Since fileDialogItem also needs to handle click events (which were previously handled by grid or list), the click event of the list seems to override the event of the item. Therefore, I moved the click event handling into fileDialogItem as well.

dialog/fileitem.go Outdated Show resolved Hide resolved
@Dorbmon Dorbmon requested a review from dweymouth April 24, 2024 16:51
dialog/fileitem.go Outdated Show resolved Hide resolved
@Dorbmon Dorbmon requested a review from dweymouth April 25, 2024 16:41
dialog/file.go Outdated Show resolved Hide resolved
dialog/fileitem.go Outdated Show resolved Hide resolved
dialog/fileitem.go Outdated Show resolved Hide resolved
Dorbmon and others added 2 commits April 26, 2024 10:42
Co-authored-by: Drew Weymouth <dweymouth@users.noreply.github.com>
@Dorbmon Dorbmon requested a review from dweymouth April 26, 2024 02:44
Copy link
Contributor

@dweymouth dweymouth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, but I think we should give @andydotxyz a chance to take another look

@dweymouth dweymouth merged commit e05c0a5 into fyne-io:develop Apr 27, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants