Fix timeout if the portal DBus is not present #4800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just update a cache when the value is found and refresh app
Jacalz
reviewed
Apr 23, 2024
app/app_xdg.go
Outdated
| func defaultVariant() fyne.ThemeVariant { | ||
| return findFreedestktopColorScheme() | ||
| return currentVariant |
There was a problem hiding this comment.
Hmm. I think this might be introducing a race condition given that it is modified in a different goroutine? Might be worth using something like an atomic.Pointer or a lock?
|
Looks like some Ubuntu/Microsoft dependency has taken down the build CI setup :( |
|
Whatever the problem was it is fixed upstream. |
Jacalz
approved these changes
Apr 30, 2024
Jacalz
requested changes
Apr 30, 2024
app/app_xdg.go
Outdated
| @@ -20,8 +20,15 @@ import ( | |||
| "fyne.io/fyne/v2/theme" | |||
| ) | |||
|
|
|||
| var currentVariant atomic.Value | |||
There was a problem hiding this comment.
Hmm. I actually have a better idea. Given that fyne.ThemeVariant is a uint, you can get cleaner and faster code by just using an atomic.Uint64 and cast the value to a fyne.ThemeVariant where loading and storing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just update a cache when the value is found and refresh app
Checklist: