Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Focus selects when tapped #4803

Merged
merged 8 commits into from May 6, 2024
Merged

Focus selects when tapped #4803

merged 8 commits into from May 6, 2024

Conversation

andydotxyz
Copy link
Member

And tidy duplicate code

Fixes #4767

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@andydotxyz
Copy link
Member Author

Hmm, the mobile tests and desktop tests are using the same XML but now have slightly different behaviour. I will have to see what to do here...

@andydotxyz andydotxyz marked this pull request as draft April 22, 2024 19:59
Jacalz
Jacalz reviewed Apr 24, 2024
View reviewed changes
Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose you'd have to move the tests into two different files? Apart from that, this looks good to me :)

@andydotxyz andydotxyz marked this pull request as ready for review May 5, 2024 13:54
@coveralls
Copy link

Coverage Status

coverage: 65.024% (+0.006%) from 65.018%
when pulling 375d165 on andydotxyz:fix/4767
into 984fa80 on fyne-io:develop.

@andydotxyz andydotxyz merged commit 748c20b into fyne-io:develop May 6, 2024
12 checks passed
@andydotxyz andydotxyz deleted the fix/4767 branch May 6, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jacalz Jacalz Jacalz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andydotxyz @coveralls @Jacalz