Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ldflags in GOFLAGS not being respected. #17

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

williambrode
Copy link

extractLdflagsFromGoFlags() was not reentrant, but we were calling it a second time when building on windows. PackageWindows does another build and the second one saw an environment with the ldflags stripped out.

This doesn't work before the change (version was not set) but it work after this change.

$Env:GOFLAGS="-ldflags=-X=path/to/pkg/config.Version=v0.0.2"
fyne package -os windows -name myapp.exe -icon ./Icon.png -appBuild 1 -appVersion 1.0.0 -appID com.example.app -tags windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant