mark mergeDefaults as pure function

g-plane · Feb 1, 2024 · 400c48b · 400c48b
1 parent 65fac62
commit 400c48b
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/visitor/src/resolve_type.rs b/visitor/src/resolve_type.rs
@@ -2,7 +2,7 @@ use crate::VueJsxTransformVisitor;
 use indexmap::{IndexMap, IndexSet};
 use std::borrow::Cow;
 use swc_core::{
-    common::{comments::Comments, EqIgnoreSpan, Spanned, DUMMY_SP},
+    common::{comments::Comments, EqIgnoreSpan, Span, Spanned, DUMMY_SP},
     ecma::{
         ast::*,
         atoms::{js_word, JsWord},
@@ -172,7 +172,13 @@ where
                         },
                     ],
                     type_args: None,
-                    span: DUMMY_SP,
+                    span: if let Some(comments) = &self.comments {
+                        let span = Span::dummy_with_cmt();
+                        comments.add_pure_comment(span.lo);
+                        span
+                    } else {
+                        DUMMY_SP
+                    },
                 })
             }
             None => Expr::Object(self.build_props_type(first_param_type, None)),

diff --git a/visitor/tests/fixture/resolve-props-types/with-defaults/output.js b/visitor/tests/fixture/resolve-props-types/with-defaults/output.js
@@ -71,7 +71,7 @@ defineComponent((props: {
 } = {
     ...defaults
 })=>{}, {
-    props: _mergeDefaults({
+    props: /*#__PURE__*/ _mergeDefaults({
         foo: {
             type: String,
             required: false
@@ -93,7 +93,7 @@ defineComponent((props: {
     bar?: number;
     baz: boolean;
 } = defaults)=>{}, {
-    props: _mergeDefaults({
+    props: /*#__PURE__*/ _mergeDefaults({
         foo: {
             type: String,
             required: false
@@ -115,7 +115,7 @@ defineComponent((props: {
         return 'foo';
     }
 })=>{}, {
-    props: _mergeDefaults({
+    props: /*#__PURE__*/ _mergeDefaults({
         foo: {
             type: Function,
             required: false