CSV/TSV use a pool of buffered readers to avoid allocs #573
+41
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use a pool of buffers to alleviate memory allocs in csv; related to #553
When iterating over multiple files, csv detector allocated a new buffer
for each file. This change adds a pool of buffers that can be reused
between detections. The same pool is shared between csv and tsv
detectors.
Benchmark results:
➜ magic git:(csvpprof) ✗ benchstat before after goos: linux goarch: amd64 pkg: github.com/gabriel-vasile/mimetype/internal/magic cpu: Intel(R) Core(TM) i7-10510U CPU @ 1.80GHz │ before │ after │ │ sec/op │ sec/op vs base │ Csv-8 3.052µ ± 3% 1.695µ ± 3% -44.46% (p=0.001 n=7) │ before │ after │ │ B/op │ B/op vs base │ Csv-8 5.258Ki ± 0% 1.164Ki ± 0% -77.86% (p=0.001 n=7) │ before │ after │ │ allocs/op │ allocs/op vs base │ Csv-8 13.00 ± 0% 11.00 ± 0% -15.38% (p=0.001 n=7)