Remove mock as dependency #161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Speaking as the new volunteer maintainer of the |
|
Hi @gabrielfalcao, Arch Linux is also moving away from mock https://archlinux.org/todo/drop-python-mock-checkdepends/. I cannot test this patch due to conflicts. Could you rebase it? Thanks! Update: https://github.com/gabrielfalcao/sure/blob/master/tests/test_assertion_builder.py also uses mock. It will be great if unittest.mock is also used there. |
archlinux-github
pushed a commit
to archlinux/svntogit-community
that referenced
this pull request
Nov 16, 2022
* Move away from python-mock [1] with a patch based on upstream one [2] * Move away from `python setup.py test` [3] as well as switching from nosetests to pytest, which is supported since 2.0.0 [4]. This allows dropping python-rednose from checkdepends but python-nose is still needed [5] * Mention myself as a maintainer [1] https://archlinux.org/todo/drop-python-mock-checkdepends/ [2] gabrielfalcao/sure#161 [3] https://archlinux.org/todo/stop-using-python-setuppy-test/ [4] gabrielfalcao/sure#175 [5] gabrielfalcao/sure#182 git-svn-id: file:///srv/repos/svn-community/svn@1349110 9fca08f4-af9d-4005-b8df-a31f2cc04f65
archlinux-github
pushed a commit
to archlinux/svntogit-community
that referenced
this pull request
Nov 16, 2022
* Move away from python-mock [1] with a patch based on upstream one [2] * Move away from `python setup.py test` [3] as well as switching from nosetests to pytest, which is supported since 2.0.0 [4]. This allows dropping python-rednose from checkdepends but python-nose is still needed [5] * Mention myself as a maintainer [1] https://archlinux.org/todo/drop-python-mock-checkdepends/ [2] gabrielfalcao/sure#161 [3] https://archlinux.org/todo/stop-using-python-setuppy-test/ [4] gabrielfalcao/sure#175 [5] gabrielfalcao/sure#182 git-svn-id: file:///srv/repos/svn-community/svn@1349110 9fca08f4-af9d-4005-b8df-a31f2cc04f65
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Summary
This is a fix for #146 following the suggestion by @adammartin-mednax to remove mock as dependency.
Additionally all tests now run with nose and pytest.