Build dateilager within the dockerfile using the nix environment #86
Conversation
airhorns
force-pushed
the
harry/multi-stage-docker
branch
from
10b9a4d
to
656a326
Compare
airhorns
force-pushed
the
harry/multi-stage-docker
branch
from
656a326
to
bc25ab3
Compare
airhorns
force-pushed
the
harry/multi-stage-docker
branch
from
bc25ab3
to
42a6646
Compare
| go install github.com/bojand/ghz/cmd/ghz@v0.110.0 | ||
| go install github.com/gadget-inc/fsdiff/cmd/fsdiff@v0.4 | ||
| go install github.com/stamblerre/gocode@latest | ||
| go install golang.org/x/tools/cmd/goimports@latest |
There was a problem hiding this comment.
Stuck these in the nix env, and then removed the ones that now come bundled with vscode (gocode => gopls, goimports is bundled also). This way, the versions used are the same in dev and in docker
| @@ -20,8 +33,11 @@ RUN mkdir -p /home/main/secrets | |||
| VOLUME /home/main/secrets/tls | |||
| VOLUME /home/main/secrets/paseto | |||
|
|
|||
| COPY release/server_linux_amd64 server | |||
| COPY --from=build-stage /app/release/server_linux_${TARGETARCH} server | |||
There was a problem hiding this comment.
Did the nice multistage thing so all the build deps aren't in the final image
| protoc-gen-go-grpc | ||
| go-migrate | ||
| mkcert | ||
| ]; |
There was a problem hiding this comment.
This makes the devShell build all the stuff you need to work on DL into your shell, but doesn't build DL itself. I always found that annoying with the original setup that I think Kira created that cd-ing into the dir built the whole project, which doesn't work so good when you are working on it and it might be busted.
There was a problem hiding this comment.
I'm down to properly Nix convert the project, it was in a very half converted state for a while.
But I do really miss the ability to control package versions, if ever Nix updates a package before we want to we're SOL.
There was a problem hiding this comment.
It's possible in nix, it's just annoying! You add a new dep at the top of a file for a nixpkgs sha that has the version of the thing you actually want, and then you refer to that version of nixpkgs in your exported packages! We did it in gadget a couple times when we didn't want to upgrade things.
airhorns
force-pushed
the
harry/multi-stage-docker
branch
from
42a6646
to
da16b06
Compare
This switches the build process to: - build DL within the dockerfile for repeatable builds, instead of copying in from outside - use the nix environment to setup the env for the build, so it's the same go version / protoc version etc etc in and outside of docker - use a multistage docker build so we have slim containers with just the binary at the end I did all this because I was fighting to get a docker image built for linux_arm64, which is what orbstack needs to run the image locally in a k8s setup! It was annoying. This also adds linux_arm64 as a build target to the makefile, and teaches the dockerfile how to build the binary for the target architecture that the dockerfile is building for. Yeesh.
airhorns
force-pushed
the
harry/multi-stage-docker
branch
from
da16b06
to
f0fc487
Compare
This switches the build process to:
I did all this because I was fighting to get a docker image built for linux_arm64, which is what orbstack needs to run the image locally in a k8s setup! It was annoying. This also adds linux_arm64 as a build target to the makefile, and teaches the dockerfile how to build the binary for the target architecture that the dockerfile is building for.
Yeesh.