Merge pull request #1278 from dgreensp/repro-hook-issue

Reproduce #1268

examples/parcel/.babelrc

@@ -1,4 +1,4 @@
 {
-  "presets": ["env", "react"],
+  "presets": ["env"],
   "plugins": ["react-hot-loader/babel", "transform-class-properties"]
 }

examples/parcel/package.json

@@ -8,15 +8,19 @@
     "start:link": "cp -R ../../dist ./node_modules/react-hot-loader && cp -R ../../*.js ./node_modules/react-hot-loader"
   },
   "devDependencies": {
-    "babel-core": "^6.26.3",
+    "@babel/core": "^7.4.5",
+    "@babel/preset-env": "^7.4.5",
     "babel-plugin-transform-class-properties": "^6.24.1",
-    "babel-preset-env": "^1.6.1",
-    "babel-preset-react": "^6.24.1",
+    "babel-preset-env": "^1.7.0",
     "parcel-bundler": "^1.12.3"
   },
   "dependencies": {
+    "@hot-loader/react-dom": "^16.8.6",
     "react": "^16.8.6",
     "react-dom": "^16.8.6",
-    "react-hot-loader": "^4.8.0"
+    "react-hot-loader": "^4.11.1"
+  },
+  "alias": {
+    "react-dom": "@hot-loader/react-dom"
   }
 }

examples/parcel/src/App.js

@@ -1,12 +1,14 @@
 import React from 'react';
 import { hot } from 'react-hot-loader';
 import Counter from './Counter';
+import { Problem } from './Problem';
 
-const App = () => (
-  <h1>
+const App = () => {
+  return <h1>
+    <Problem/>
     Hello, world.<br />
     <Counter />
   </h1>
-);
+};
 
 export default hot(module)(App);

examples/parcel/src/Counter.js

@@ -17,3 +17,7 @@ class Counter extends React.Component {
 }
 
 export default Counter;
+
+export function useExternalHook() {
+  React.useEffect(() => {})
+}

examples/parcel/src/Problem.js

@@ -0,0 +1,6 @@
+import { useExternalHook } from './Counter'
+
+export function Problem() {
+    useExternalHook()
+    return null
+}

examples/parcel/src/index.js

@@ -3,10 +3,9 @@ import { render } from 'react-dom';
 import App from './App';
 
 function renderApp() {
-  const App = require('./App').default;
   render(<App />, root);
 }
 
 renderApp();
 
-module.hot.accept(renderApp);
+module.hot.accept();