Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discourage using webpack loader for all the files #1452

Merged
merged 1 commit into from May 12, 2020
Merged

Discourage using webpack loader for all the files #1452

merged 1 commit into from May 12, 2020

Conversation

wojtekmaj
Copy link
Contributor

  • Replaces the phrase "It is safe to enable this loader for all the files" with "It is possible to enable...", because it's neither safe (as proven in react-hot-loader may break the app in Webpack 5.0.0-beta.14 and up #1449) nor usually necessary.
  • Switches first example of Webpack config (suboptimal, applying loader to all the files) with the second one (optimal, applying loader to react-dom only, if you're using babel plugin)

theKashey
theKashey requested changes May 11, 2020
View reviewed changes
Copy link
Collaborator

@theKashey theKashey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one small change

README.md Outdated Show resolved Hide resolved
@wojtekmaj
Discourage using webpack loader for all the files
0688a52 
* Replaces the phrase "It is safe to enable this loader for all the files" with "It is _possible_ to enable...", because it's neither safe (as proven in #1449) nor usually necessary.
* Switches first example of Webpack config (suboptimal, applying loader to all the files) with the second one (optimal, applying loader to react-dom only, if you're using babel plugin)
@wojtekmaj wojtekmaj requested a review from theKashey May 12, 2020 06:10
@theKashey theKashey merged commit 92961be into gaearon:master May 12, 2020
@theKashey
Copy link
Collaborator

👍

@wojtekmaj wojtekmaj deleted the wmaj/discourage-webpack-loader branch May 12, 2020 07:17
@wojtekmaj wojtekmaj mentioned this pull request Oct 16, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theKashey theKashey Awaiting requested review from theKashey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wojtekmaj @theKashey