Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update electron from 17.1.2 to 17.4.3 #108

Merged
merged 1 commit into from May 10, 2022
Merged

Update electron from 17.1.2 to 17.4.3 #108

merged 1 commit into from May 10, 2022

Conversation

p2004a
Copy link
Contributor

@p2004a p2004a commented May 10, 2022

That's only patch update so no backward incompatible changes, I don't see any issues.

Motivation: It contains my fixed for running under Wayland electron/electron#33355 and nobody detected any issues there so far, so we can experiment with runnning both game and launcher natively on wayland.

cc @Beherith, as you can imagine, would love to have it in the Wednesday release 馃槈

@gajop gajop merged commit 5ccab82 into gajop:master May 10, 2022
@gajop
Copy link
Owner

gajop commented May 10, 2022

Thanks!

Regarding the Wednesday release, do you want to update the prd included in this repo as well?

@p2004a
Copy link
Contributor Author

p2004a commented May 10, 2022

The update in the BAR repo is this commit: beyond-all-reason@284dc1f I'm not sure how to in the cleanest way include here so there aren't any merge conflicts?

@gajop
Copy link
Owner

gajop commented May 10, 2022

I'm tempted to just copy it =)

@p2004a p2004a mentioned this pull request May 11, 2022
@p2004a p2004a deleted the update-electron branch August 7, 2022 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants