Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ESLint 8.x #33

Closed
wants to merge 1 commit into from

Conversation

MichaelDeBoey
Copy link

@MichaelDeBoey MichaelDeBoey commented Oct 10, 2021

ESLint v8.0.0 is released 馃帀

Dependencies should be compatible with ESLint 8 too before we can merge this one:


Closes #32

package.json Outdated Show resolved Hide resolved
Copy link
Author

@MichaelDeBoey MichaelDeBoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gajus We have 2 deprecated dependencies.

How would you like to handle them?

package.json Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
BREAKING CHANGE: Requires Node@^12.22.0 || ^14.17.0 || >=16.0.0
BREAKING CHANGE: Requires ESLint@^8.0.0
@julienw
Copy link

julienw commented Oct 25, 2021

Travis fails because of the flowtype plugin, but the flowtype plugin v8 PR fails because of this package. So there's a cycle dependency here, and you might need to have a failed Travis for some time.

@gajus
Copy link
Owner

gajus commented Oct 25, 2021

FYI eslint-plugin-sort-keys-fix plugin is no longer being used.

Replaced by https://github.com/gajus/eslint-plugin-canonical#eslint-plugin-canonical-rules-sort-keys

@gajus
Copy link
Owner

gajus commented Oct 25, 2021

FYI eslint-plugin-filenames plugin is no longer being used.

Replaced by https://github.com/gajus/eslint-plugin-canonical#eslint-plugin-canonical-rules

@gajus
Copy link
Owner

gajus commented Oct 25, 2021

FYI eslint-plugin-no-use-extend-native plugin is no longer being used.

@gajus
Copy link
Owner

gajus commented Oct 25, 2021

eslint-plugin-mocha does not require any release to support v8.

lo1tuma/eslint-plugin-mocha#298

@gajus
Copy link
Owner

gajus commented Oct 26, 2021

The remaining work depends on the mentioned packages to update.

@gajus gajus closed this Oct 26, 2021
@MichaelDeBoey MichaelDeBoey deleted the eslint-8 branch November 14, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ESLint 8.x
3 participants