Add respect to @noflow annotation
#451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 29, 2020 17:08
…onlyFilesWithFlowAnnotation` should not be enabled and file not marked with @noflow
…leAnnotation` - respect onlyFilesWithFlowAnnotation == true
| @@ -88,7 +88,7 @@ export default { | |||
| recommended, | |||
| }, | |||
| rules: _.mapValues(rules, (rule, key) => { | |||
| if (key === 'no-types-missing-file-annotation') { | |||
| if (['no-types-missing-file-annotation', 'require-valid-file-annotation'].includes(key)) { | |||
There was a problem hiding this comment.
Had to change the way how require-valid-file-annotation works with onlyFilesWithFlowAnnotation setting, because of breaking change in checkFlowFileAnnotation.js
| return false; | ||
| } | ||
|
|
||
| return !strict || match[0] === '@noflow'; |
There was a problem hiding this comment.
This file is a copy of "isFlowFileAnnotation.js" with only changes in regex and on this line
|
@gajus is there any way I can help advance this PR? |
|
🎉 This PR is included in version 5.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #450
Added respect to
@noflowannotation.Notice:
npm run create-readmedidn't work for me - failed with errorBranch ("master") definition does not exist in the config