feat: new interfaceTypeIdMatch rule #491
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brianzchen
reviewed
Aug 2, 2021
.README/README.md
Outdated
Comment on lines
57
to
60
| "flowtype/interface-type-id-match": [ | ||
| 2, | ||
| "^([A-Z][a-z0-9]+)+Type$" | ||
| ], |
There was a problem hiding this comment.
Don't think is necessary, but fine to keep.
src/rules/interfaceTypeIdMatch.js
Outdated
| const typeIdentifierName = interfaceDeclarationNode.id.name; | ||
|
|
||
| if (!pattern.test(typeIdentifierName)) { | ||
| context.report(interfaceDeclarationNode, 'Type identifier \'{{name}}\' does not match pattern \'{{pattern}}\'.', { |
There was a problem hiding this comment.
Suggested change
| context.report(interfaceDeclarationNode, 'Type identifier \'{{name}}\' does not match pattern \'{{pattern}}\'.', { | |
| context.report(interfaceDeclarationNode, 'Interface identifier \'{{name}}\' does not match pattern \'{{pattern}}\'.', { |
src/rules/interfaceTypeIdMatch.js
Outdated
| const pattern = new RegExp(context.options[0] || '^([A-Z][a-z0-9]*)+Type$'); | ||
|
|
||
| const checkType = (interfaceDeclarationNode) => { | ||
| const typeIdentifierName = interfaceDeclarationNode.id.name; |
There was a problem hiding this comment.
Suggested change
| const typeIdentifierName = interfaceDeclarationNode.id.name; | |
| const interfaceIdentifierName = interfaceDeclarationNode.id.name; |
src/rules/interfaceTypeIdMatch.js
Outdated
| const create = (context) => { | ||
| const pattern = new RegExp(context.options[0] || '^([A-Z][a-z0-9]*)+Type$'); | ||
|
|
||
| const checkType = (interfaceDeclarationNode) => { |
There was a problem hiding this comment.
Suggested change
| const checkType = (interfaceDeclarationNode) => { | |
| const checkInterface = (interfaceDeclarationNode) => { |
tests/rules/index.js
Outdated
| @@ -19,6 +19,7 @@ const reportingRules = [ | |||
| 'delimiter-dangle', | |||
| 'enforce-line-break', | |||
| 'generic-spacing', | |||
| 'interface-type-id-match', | |||
There was a problem hiding this comment.
Suggested change
| 'interface-type-id-match', | |
| 'interface-id-match', |
|
closing in favour of #492 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves #483
cc: @gajus @angelica-bocanegra @Brianzchen