perf: improve performance for rules (#856)

gajus · Mar 26, 2022 · 33eb99e · 33eb99e
1 parent ba9ddf6
commit 33eb99e
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/iterateJsdoc.js b/src/iterateJsdoc.js
@@ -979,7 +979,7 @@ const getIndentAndJSDoc = function (lines, jsdocNode) {
  * @param {boolean} additiveContexts
  */
 const iterateAllJsdocs = (iterator, ruleConfig, contexts, additiveContexts) => {
-  const trackedJsdocs = [];
+  const trackedJsdocs = new Set();
 
   let handler;
   let settings;
@@ -1107,7 +1107,7 @@ const iterateAllJsdocs = (iterator, ruleConfig, contexts, additiveContexts) => {
           }
 
           const commentNode = getJSDocComment(sourceCode, node, settings);
-          if (trackedJsdocs.includes(commentNode)) {
+          if (trackedJsdocs.has(commentNode)) {
             return;
           }
 
@@ -1122,15 +1122,15 @@ const iterateAllJsdocs = (iterator, ruleConfig, contexts, additiveContexts) => {
             return;
           }
 
-          trackedJsdocs.push(commentNode);
+          trackedJsdocs.add(commentNode);
           callIterator(context, node, [
             commentNode,
           ], state);
         },
         'Program:exit' () {
           const allComments = sourceCode.getAllComments();
           const untrackedJSdoc = allComments.filter((node) => {
-            return !trackedJsdocs.includes(node);
+            return !trackedJsdocs.has(node);
           });
 
           callIterator(context, null, untrackedJSdoc, state, true);