fix(valid-types): allow and require types on @extends for TypeScr…

…ipt as used in docs (and not name)
gajus · Jul 18, 2021 · 6989699 · 6989699
1 parent 52d7eff
commit 6989699
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 3 deletions.
diff --git a/README.md b/README.md
@@ -20538,6 +20538,12 @@ type ComplicatedType<T, U, V, W, X> = never
  *   prop: number
  * }} MyOptions
  */
+
+/**
+ * @extends {SomeType}
+ */
+class quux {}
+// Settings: {"jsdoc":{"mode":"typescript"}}
 ````
 
 
diff --git a/src/getDefaultTagStructureForMode.js b/src/getDefaultTagStructureForMode.js
@@ -163,12 +163,12 @@ const getDefaultTagStructureForMode = (mode) => {
       ['nameContents', 'namepath-referencing'],
 
       // Does not show curly brackets in either the signature or examples
-      ['typeAllowed', isClosureOrPermissive],
+      ['typeAllowed', isTypescriptOrClosure || isPermissive],
 
-      ['nameRequired', isJsdocOrTypescript],
+      ['nameRequired', isJsdoc],
 
       // "namepath"
-      ['typeOrNameRequired', isClosureOrPermissive],
+      ['typeOrNameRequired', isTypescriptOrClosure || isPermissive],
     ])],
 
     ['external', new Map([

diff --git a/test/rules/assertions/validTypes.js b/test/rules/assertions/validTypes.js
@@ -1264,5 +1264,19 @@ export default {
         sourceType: 'module',
       },
     },
+    {
+      code: `
+      /**
+       * @extends {SomeType}
+       */
+      class quux {}
+
+      `,
+      settings: {
+        jsdoc: {
+          mode: 'typescript',
+        },
+      },
+    },
   ],
 };