fix(require-jsdoc): avoid erring (or traversing) on object spread i…

…n parsing for defined symbols; fixes #378
gajus · Oct 23, 2019 · 6ab617f · 6ab617f
1 parent 022d5da
commit 6ab617f
Show file tree

Hide file tree

Showing 3 changed files with 36 additions and 0 deletions.
diff --git a/README.md b/README.md
@@ -6013,6 +6013,10 @@ enum Example {
   test = 123
 }
 // Options: [{"contexts":["TSEnumDeclaration"]}]
+
+const foo = {...{}};
+function bar() {}
+// Options: [{"exemptEmptyFunctions":false,"publicOnly":true,"require":{"ArrowFunctionExpression":true,"ClassDeclaration":true,"ClassExpression":true,"FunctionDeclaration":true,"FunctionExpression":false,"MethodDefinition":true}}]
 ````
 
 

diff --git a/src/exportParser.js b/src/exportParser.js
@@ -105,6 +105,9 @@ const getSymbol = function (node, globals, scope, opt) {
     const val = createNode();
     val.type = 'object';
     node.properties.forEach((prop) => {
+      if (prop.type === 'ExperimentalSpreadProperty') {
+        return;
+      }
       const propVal = getSymbol(prop.value, globals, scope, opts);
       /* istanbul ignore next */
       if (propVal) {

diff --git a/test/rules/assertions/requireJsdoc.js b/test/rules/assertions/requireJsdoc.js
@@ -2325,5 +2325,34 @@ export default {
       sourceType: 'module',
     },
   },
+  {
+    // https://github.com/gajus/eslint-plugin-jsdoc/issues/378
+    code: `
+    const foo = {...{}};
+    function bar() {}
+    `,
+    options: [
+      {
+        exemptEmptyFunctions: false,
+        publicOnly: true,
+        require: {
+          ArrowFunctionExpression: true,
+          ClassDeclaration: true,
+          ClassExpression: true,
+          FunctionDeclaration: true,
+          FunctionExpression: false,
+          MethodDefinition: true,
+        },
+      },
+    ],
+    parser: require.resolve('babel-eslint'),
+    parserOptions: {
+      ecmaFeatures: {
+        jsx: true,
+      },
+      ecmaVersion: 2017,
+      sourceType: 'module',
+    },
+  },
   ],
 };