semver.valid() requires trimmed string

With leading or trailing whitespace, semver.valid() returns false
gajus · Jan 15, 2020 · b32ee6a · b32ee6a
1 parent 422a48e
commit b32ee6a
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/rules/checkValues.js b/src/rules/checkValues.js
@@ -15,8 +15,8 @@ export default iterateJsdoc(({
   } = options;
 
   utils.forEachPreferredTag('version', (jsdocParameter, targetTagName) => {
-    const version = jsdocParameter.description;
-    if (!version.trim()) {
+    const version = jsdocParameter.description.trim();
+    if (!version) {
       report(
         `Missing JSDoc @${targetTagName}.`,
         null,
@@ -31,8 +31,8 @@ export default iterateJsdoc(({
     }
   });
   utils.forEachPreferredTag('since', (jsdocParameter, targetTagName) => {
-    const version = jsdocParameter.description;
-    if (!version.trim()) {
+    const version = jsdocParameter.description.trim();
+    if (!version) {
       report(
         `Missing JSDoc @${targetTagName}.`,
         null,