fix(valid-types): ensure reporting "must have a type" when type is …

…known to be required
gajus · Dec 1, 2019 · b36053e · b36053e
1 parent b6e2699
commit b36053e
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 1 deletion.
diff --git a/README.md b/README.md
@@ -9065,6 +9065,13 @@ function quux () {}
  function quux () {}
 // Settings: {"jsdoc":{"mode":"closure"}}
 // Message: Tag @define must have a type
+
+/**
+ * @this
+ */
+ let foo;
+// Settings: {"jsdoc":{"mode":"closure"}}
+// Message: Tag @this must have a type
 ````
 
 The following patterns are not considered problems:

diff --git a/src/rules/validTypes.js b/src/rules/validTypes.js
@@ -97,7 +97,7 @@ export default iterateJsdoc(({
         validNamepathParsing(thatNamepath);
       }
     } else {
-      if (mustHaveEither && !hasEither) {
+      if (mustHaveEither && !hasEither && !mustHaveTypePosition) {
         report(`Tag @${tag.tag} must have either a type or namepath`, null, tag);
 
         return;

diff --git a/test/rules/assertions/validTypes.js b/test/rules/assertions/validTypes.js
@@ -323,6 +323,25 @@ export default {
         },
       },
     },
+    {
+      code: `
+          /**
+           * @this
+           */
+           let foo;
+      `,
+      errors: [
+        {
+          line: 3,
+          message: 'Tag @this must have a type',
+        },
+      ],
+      settings: {
+        jsdoc: {
+          mode: 'closure',
+        },
+      },
+    },
   ],
   valid: [
     {