changed regex to matchAll

gajus · Apr 7, 2022 · b5027aa · b5027aa
1 parent dbec8b2
commit b5027aa
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 12 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -2,7 +2,6 @@ os: linux
 dist: xenial
 language: node_js
 node_js:
-  - "12.22.0"
   - "14.17.0"
   - "16"
 install:

diff --git a/package.json b/package.json
@@ -47,7 +47,7 @@
     "typescript": "^4.6.3"
   },
   "engines": {
-    "node": "^12 || ^14 || ^16 || ^17"
+    "node": "^14 || ^16 || ^17"
   },
   "keywords": [
     "eslint",

diff --git a/src/rules/requireDescriptionCompleteSentence.js b/src/rules/requireDescriptionCompleteSentence.js
@@ -22,16 +22,9 @@ const extractSentences = (text, abbreviationsRegex) => {
     // Remove custom abbreviations
     .replace(abbreviationsRegex, '');
 
-  const sentenceEndGrouping = /([.?!])(?:\s+|$)/u;
-
-  const puncts = [];
-  let matches;
-  let n0;
-  let index = 0;
-  while ((matches = sentenceEndGrouping.exec(txt)) !== null) {
-    n0 = matches.splice(0, 1);
-    puncts.push(matches.concat(index++, n0));
-  }
+  const sentenceEndGrouping = /([.?!])(?:\s+|$)/ug;
+
+  const puncts = txt.matchAll(sentenceEndGrouping);
 
   return txt