fix(require-yields): check test part of if expression and check c…

…onditionals
gajus · Jan 31, 2021 · db001be · db001be
1 parent de345cf
commit db001be
Show file tree

Hide file tree

Showing 2 changed files with 39 additions and 1 deletion.
diff --git a/src/jsdocUtils.js b/src/jsdocUtils.js
@@ -747,8 +747,10 @@ const hasYieldValue = (node, checkYieldReturnValue) => {
   case 'WithStatement': {
     return hasYieldValue(node.body, checkYieldReturnValue);
   }
+  case 'ConditionalExpression':
   case 'IfStatement': {
-    return hasYieldValue(node.consequent, checkYieldReturnValue) ||
+    return hasYieldValue(node.test, checkYieldReturnValue) ||
+      hasYieldValue(node.consequent, checkYieldReturnValue) ||
       hasYieldValue(node.alternate, checkYieldReturnValue);
   }
   case 'TryStatement': {

diff --git a/test/rules/assertions/requireYields.js b/test/rules/assertions/requireYields.js
@@ -536,6 +536,42 @@ export default {
         },
       ],
     },
+    {
+      code: `
+          /**
+           *
+           */
+          function * quux () {
+            if (yield false) {
+
+            }
+          }
+      `,
+      errors: [
+        {
+          line: 2,
+          message: 'Missing JSDoc @yields declaration.',
+        },
+      ],
+      ignoreReadme: true,
+    },
+    {
+      code: `
+          /**
+           *
+           */
+          function * quux () {
+            b ? yield false : true
+          }
+      `,
+      errors: [
+        {
+          line: 2,
+          message: 'Missing JSDoc @yields declaration.',
+        },
+      ],
+      ignoreReadme: true,
+    },
     {
       code: `
           /**