removed regextra library to reduce dependencies #865
Conversation
|
Ok, but can we see about using matchAll instead of |
|
Sounds good to me, thanks for the fast response! Updating it now |
|
and so that the tests pass, feel free to add the Node version bump to |
ChrisDryden
force-pushed
the
regextradependencyremoval
branch
from
b7ff839
to
b5027aa
Compare
|
Removed the node12 support and made the matchAll changes. One of the four builds is failing and it appears to be unrelated to the changes, would it be possible to take a quick look or rerun the CI? |
|
I've filed gajus/eslint-plugin-canonical#4 as such a fix should get our tests working again. |
brettz9
force-pushed
the
regextradependencyremoval
branch
from
915476b
to
c8781d2
Compare
|
I discovered that we could probably live with Thanks for the PR! |
|
🎉 This PR is included in version 39.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [eslint-plugin-jsdoc](https://github.com/gajus/eslint-plugin-jsdoc) | devDependencies | major | [`38.1.6` -> `39.0.0`](https://renovatebot.com/diffs/npm/eslint-plugin-jsdoc/38.1.6/39.0.0) | --- ### Release Notes <details> <summary>gajus/eslint-plugin-jsdoc</summary> ### [`v39.0.0`](https://github.com/gajus/eslint-plugin-jsdoc/releases/v39.0.0) [Compare Source](gajus/eslint-plugin-jsdoc@v38.1.6...v39.0.0) ##### chore - drop Node 12 from `engines` ([be3af9d](gajus/eslint-plugin-jsdoc@be3af9d)), closes [#​865](gajus/eslint-plugin-jsdoc#865) ##### BREAKING CHANGES - Node 12 is soon entering EOL. Also: </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [x] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1293 Reviewed-by: crapStone <crapstone@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
We currently have three seperate security advisories for this package due to the sub packages of regextras. I noticed that there is only one use of the regextras package and it could be replaced with only a few lines and would signifigantly reduce the size of the package and the impact of the downstream dependencies.