require-returns
: check for Promise
executor
#683
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(
require-returns
): if function returns a Promise whose executor resolves with undefined, avoid need to document unlessforceReturnsWithAsync
is set; fixes #550Note that if this is merged, #682 will need to add mention that our
resolve
detection is not fully complete either, since there are more edge cases where this PR does not check. But I expect it is a good beginning.