feat: new rule tag-line; fixes #93
#727
Conversation
brettz9
force-pushed
the
tag-lines
branch
4 times, most recently
from
46e0112
to
630421d
Compare
|
What does |
|
There are tests for it |
|
Do you think it would be better if the always/never options is dropped, and that fee "count: 0" means no empty lines are allowed? |
The one reason I thought it may be ok, as is, is because we can have a sensible defaults for "always" which avoids the need for specifying a number in that case as with "never". But I'm ok with switching it if you think it should be changed. I've updated, btw, so the line number tests/fixes and added test should otherwise be ready for review. |
.README/rules/tag-lines.md
Outdated
|
|
||
| ##### `noEndLine` (defaults to `false`) | ||
|
|
||
| Use with "always" to indicate tag lines should not be added at the end. |
There was a problem hiding this comment.
I don't understand this option. What is a tag line?
There was a problem hiding this comment.
Clarified to state:
Use with "always" to indicate the normal lines to be added after tags should
not be added after the final tag.
Also changed noEndLine to noEndLines as can be more than one between tags normally.
…to `code` rather than `whitespace`
|
🎉 This PR is included in version 34.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Includes a
alwaysvs.neveroption as well as two special options foralways(countandnoEndLine). Fixes #93.