fix(check-line-alignment): Fix line alignment when no types are present

[TGCrystal]

This fixes #894, along with a few additional edge cases I discovered along the way.

I tried to keep my fix structured similar to how the initial change works. It does still kind of seem like a hack, so let me know if there is a different approach I should take.

If I made an incorrect assumption when creating the test cases and any of them should actually be invalid, let me know. I am willing to make changes to this pr.

[brettz9]

Thanks for the PR. It looks like some tests are failing, apparently relating to decorators. Not sure where the problem might lie... It appears some dependency has since changed behavior.

[TGCrystal]

Looks like TypeScript had a release shortly before I made the pr https://github.com/microsoft/TypeScript/releases/tag/v4.8.2

I tested on the master branch on a fresh clone of this repo and it was having the same error.

Specifying <4.8.0 as the TypeScript version seems to fix it, at least locally. From this comment it seems some things with decorators changed. Not sure if this directly impacts this repo or does so through @typescript-eslint/parser (which has an open pr to support TypeScript 4.8 here. For the time being, I just changed package.json to keep TypeScript below 4.8.0.

[TGCrystal]

Typescript-eslint was updated to support Typescript 4.8, so I reverted the commit I made to force the TypeScript version below 4.8.0. Deleting node_modules and package-lock.json and reinstalling now works locally, but Travis CI is still using the checks from when it initially failed. Is there a way I can force them to rerun?

[brettz9]

Thanks for the issue and PR! Re-running took care of the issue (something I believe GH only allows those with the specific access to do).

[MorevM]

@brettz9 any chance for this to be released?
Last release was on 9 August, and #894 still an issue in 39.3.6

[brettz9]

@gajus , do you have any idea why npm has not been publishing? I had forgotten that npm is now requiring 2FA, and only fixed my personal npm account to use 2FA just now, but I figure maybe it needs a fix in Travis configuration?