fix: do not proxy traffic to sockets #60
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements a proxy-exception for traffic targeting local sockets instead of a "host:port" combination. If such traffic would be forwarded through the proxy, the socket destination info would be lost, while a "localhost:80" destination would be added. This means that the proxy cannot handle such requests correctly either way, which makes sending traffic to the proxy pointless. Because of that, if the agent receives traffic destined for a socket, it will simply use the fallback agent to handle that traffic.
tommyknows
added a commit
to snyk/cli
that referenced
this pull request
Oct 18, 2022
For CLIv2, all traffic is proxied through a local server that the CLIv2 spawns. This is achieved by updating the `http.globalAgent` and `http.request` and `http.get` functions through the `global-agent` library. However, this causes issues with HTTP traffic that is supposed to go to local sockets. For example, `snyk container` talks to the `/var/run/docker.sock` socket for doing some image operations (if the socket exists). When the http agent and functions are replaced, this causes traffic to the socket to be routed to / through the proxy, and because at that point it is "proper" HTTP traffic, the destination is not the socket anymore but `localhost:80` (the fallback). The proxy has no way of handling this correctly, as all the information of the socket is lost. To fix this, there would have been two possibilities: - Make it possible to use custom agents. Currently, even if a user creates a custom agent and passes it to `http.request` or `http.get`, this custom agent will not be used. This is because the `global-agent` library *enforces* the usage of the proxy-agent. There is a flag to change this behaviour (`forceGLobalAgent`), but we do not want to use this as traffic should *always* go through the proxy. - Fix the `global-agent` library to not use the proxy-agent if traffic is supposed to go to sockets. A [PR](gajus/global-agent#60) has been raised on the library, but the repository seems to be unmaintaned. Because we need this fix to continue with the app vulnerability enablement, this commit adds a `postinstall` hook that patches the library in the `node-modules` folder through a `git apply` command. With the applied patch, traffic to the Docker socket (and all other sockets) will not be rerouted through the proxy anymore.
tommyknows
added a commit
to snyk/cli
that referenced
this pull request
Oct 18, 2022
For CLIv2, all traffic is proxied through a local server that the CLIv2 spawns. This is achieved by updating the `http.globalAgent` and `http.request` and `http.get` functions through the `global-agent` library. However, this causes issues with HTTP traffic that is supposed to go to local sockets. For example, `snyk container` talks to the `/var/run/docker.sock` socket for doing some image operations (if the socket exists). When the http agent and functions are replaced, this causes traffic to the socket to be routed to / through the proxy, and because at that point it is "proper" HTTP traffic, the destination is not the socket anymore but `localhost:80` (the fallback). The proxy has no way of handling this correctly, as all the information of the socket is lost. To fix this, there would have been two possibilities: - Make it possible to use custom agents. Currently, even if a user creates a custom agent and passes it to `http.request` or `http.get`, this custom agent will not be used. This is because the `global-agent` library *enforces* the usage of the proxy-agent. There is a flag to change this behaviour (`forceGLobalAgent`), but we do not want to use this as traffic should *always* go through the proxy. - Fix the `global-agent` library to not use the proxy-agent if traffic is supposed to go to sockets. A [PR](gajus/global-agent#60) has been raised on the library, but the repository seems to be unmaintaned. Because we need this fix to continue with the app vulnerability enablement, this commit adds a `postinstall` hook that patches the library in the `node-modules` folder through a `git apply` command. With the applied patch, traffic to the Docker socket (and all other sockets) will not be rerouted through the proxy anymore.
tommyknows
added a commit
to snyk/cli
that referenced
this pull request
Oct 19, 2022
For CLIv2, all traffic is proxied through a local server that the CLIv2 spawns. This is achieved by updating the `http.globalAgent` and `http.request` and `http.get` functions through the `global-agent` library. However, this causes issues with HTTP traffic that is supposed to go to local sockets. For example, `snyk container` talks to the `/var/run/docker.sock` socket for doing some image operations (if the socket exists). When the http agent and functions are replaced, this causes traffic to the socket to be routed to / through the proxy, and because at that point it is "proper" HTTP traffic, the destination is not the socket anymore but `localhost:80` (the fallback). The proxy has no way of handling this correctly, as all the information of the socket is lost. To fix this, there would have been two possibilities: - Make it possible to use custom agents. Currently, even if a user creates a custom agent and passes it to `http.request` or `http.get`, this custom agent will not be used. This is because the `global-agent` library *enforces* the usage of the proxy-agent. There is a flag to change this behaviour (`forceGLobalAgent`), but we do not want to use this as traffic should *always* go through the proxy. - Fix the `global-agent` library to not use the proxy-agent if traffic is supposed to go to sockets. A [PR](gajus/global-agent#60) has been raised on the library, but the repository seems to be unmaintaned. Because we need this fix to continue with the app vulnerability enablement, this commit adds a `postinstall` hook that patches the library in the `node-modules` folder through a `git apply` command. With the applied patch, traffic to the Docker socket (and all other sockets) will not be rerouted through the proxy anymore.
1 task
ChristinaDara
pushed a commit
to snyk/cli
that referenced
this pull request
Jan 23, 2023
For CLIv2, all traffic is proxied through a local server that the CLIv2 spawns. This is achieved by updating the `http.globalAgent` and `http.request` and `http.get` functions through the `global-agent` library. However, this causes issues with HTTP traffic that is supposed to go to local sockets. For example, `snyk container` talks to the `/var/run/docker.sock` socket for doing some image operations (if the socket exists). When the http agent and functions are replaced, this causes traffic to the socket to be routed to / through the proxy, and because at that point it is "proper" HTTP traffic, the destination is not the socket anymore but `localhost:80` (the fallback). The proxy has no way of handling this correctly, as all the information of the socket is lost. To fix this, there would have been two possibilities: - Make it possible to use custom agents. Currently, even if a user creates a custom agent and passes it to `http.request` or `http.get`, this custom agent will not be used. This is because the `global-agent` library *enforces* the usage of the proxy-agent. There is a flag to change this behaviour (`forceGLobalAgent`), but we do not want to use this as traffic should *always* go through the proxy. - Fix the `global-agent` library to not use the proxy-agent if traffic is supposed to go to sockets. A [PR](gajus/global-agent#60) has been raised on the library, but the repository seems to be unmaintaned. Because we need this fix to continue with the app vulnerability enablement, this commit adds a `postinstall` hook that patches the library in the `node-modules` folder through a `git apply` command. With the applied patch, traffic to the Docker socket (and all other sockets) will not be rerouted through the proxy anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements a proxy-exception for traffic targeting local sockets instead of a "host:port" combination. If such traffic would be forwarded through the proxy, the socket destination info would be lost, while a "localhost:80" destination would be added. This means that the proxy cannot handle such requests correctly either way, which makes sending traffic to the proxy pointless.
Because of that, if the agent receives traffic destined for a socket, it will simply use the fallback agent to handle that traffic.
Fixes #59.